Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stale rule from Makefile #1782

Merged
merged 1 commit into from
May 25, 2017
Merged

Remove stale rule from Makefile #1782

merged 1 commit into from
May 25, 2017

Conversation

ethantkoenig
Copy link
Member

make integration is left over from the old integration test framework; the current framework uses the make test-(DB) rules

@strk
Copy link
Member

strk commented May 23, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2017
@andreynering
Copy link
Contributor

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 23, 2017
@ethantkoenig
Copy link
Member Author

Build timed out 😢

@ethantkoenig
Copy link
Member Author

Rebased onto master to retrigger CI build

@lunny lunny added this to the 1.2.0 milestone May 24, 2017
@lunny lunny added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label May 24, 2017
@appleboy
Copy link
Member

build error:

/srv/app/src/code.gitea.io/gitea/routers/repo/repo.go:71:65: invalid operation: ctx.User (variable of type *code.gitea.io/gitea/models.User) has no field or method RepoCreationNum

@ethantkoenig
Copy link
Member Author

@appleboy See #1786

@sapk
Copy link
Member

sapk commented May 24, 2017 •
edited
Loading

Build time out. This PR could be merge without build check.

@lunny
Copy link
Member

lunny commented May 25, 2017

make L-G-T-M work

@lunny lunny merged commit cb74f1b into go-gitea:master May 25, 2017
@ethantkoenig ethantkoenig deleted the makefile branch May 30, 2017 13:58
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ethantkoenig @strk @andreynering @appleboy @sapk @lunny @tboerger