Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle display of GPG key without end date #1628

Merged
merged 1 commit into from
Apr 28, 2017

Conversation

sapk
Copy link
Member

@sapk sapk commented Apr 27, 2017

All is in the title.

Reported by @Fastidious in a comment on @8371f94d06cefbd65392af3b5c0f1fd1057429f7
(related issue #1626 )

Before :
after

After :
after

@sapk
Copy link
Member Author

sapk commented Apr 27, 2017

This will need to push new ini to crowdin. cc @lunny

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 27, 2017
@appleboy
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 28, 2017
@lunny lunny added this to the 1.2.0 milestone Apr 28, 2017
@lunny lunny added the type/bug label Apr 28, 2017
@lunny
Copy link
Member

lunny commented Apr 28, 2017

LGTM. @sapk OK. I will update the ini after this merged.

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 28, 2017
@lunny lunny merged commit 431b26f into go-gitea:master Apr 28, 2017
@sapk sapk deleted the gpg-handle-nil-expire-date branch April 28, 2017 10:03
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants