Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone styling improvements #15291

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Dropzone styling improvements #15291

merged 2 commits into from
Apr 9, 2021

Conversation

silverwind
Copy link
Member

  • Move all dropzone styles to separate file
  • Fix white background in arc-green
  • Fix rendering of non-square images and previews

Before:
Screen Shot 2021-04-05 at 15 28 16

After:
Screen Shot 2021-04-05 at 15 29 25

@silverwind silverwind added the topic/ui Change the appearance of the Gitea UI label Apr 5, 2021
@silverwind silverwind added this to the 1.15.0 milestone Apr 5, 2021
@silverwind silverwind force-pushed the dropzonefix branch 3 times, most recently from 49034dd to 9b3cf41 Compare April 5, 2021 14:04
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 5, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 7, 2021
- Move all dropzone styles to separate file
- Fix white background in arc-green
- Fix rendering of non-square images and previews
@silverwind
Copy link
Member Author

silverwind commented Apr 9, 2021

Added a few more minor improvements. Increased thumbnail preview quality 4-times and replaced the hideous blur effect dropzone does with opacity, this is how it looks now when hovering a thumbnail:

Screen Shot 2021-04-09 at 18 13 10

Screen Shot 2021-04-09 at 18 13 21

Also, adding the backport label as this is a nice quality improvment.

@lunny lunny merged commit afa781b into go-gitea:master Apr 9, 2021
@silverwind silverwind deleted the dropzonefix branch April 9, 2021 16:53
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 9, 2021
* Dropzone styling improvements

- Move all dropzone styles to separate file
- Fix white background in arc-green
- Fix rendering of non-square images and previews

* increase thumbnail quality, set contain in js, replace blur effect with opacity
@silverwind silverwind added the backport/done All backports for this PR have been created label Apr 9, 2021
techknowlogick added a commit that referenced this pull request Apr 9, 2021
* Dropzone styling improvements

- Move all dropzone styles to separate file
- Fix white background in arc-green
- Fix rendering of non-square images and previews

* increase thumbnail quality, set contain in js, replace blur effect with opacity

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants