Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repo size in admin panel #1482

Merged
merged 3 commits into from
Apr 11, 2017
Merged

Repo size in admin panel #1482

merged 3 commits into from
Apr 11, 2017

Conversation

cez81
Copy link
Contributor

@cez81 cez81 commented Apr 10, 2017

Add repository size to repo list in admin panel. Replacement for #39

DblK and others added 3 commits April 11, 2017 00:51
@DblK @cez81
Implementation of the feature to view repository size in admin panel
b5f1205 
 * Move GetRepoSize to git module
 * Repository.RepoSize -> Repository.Size
 * RepoSize -> Size in template
 * Redo a few bits and pieces
 * Update size when syncing mirror or forking
 * Remove GetRepoSize
 * Changed fatal errors to error message
@cez81
Copy migration code from Gogs
6899773
@cez81
make fmt
0247cb7
@lunny lunny added this to the 1.2.0 milestone Apr 11, 2017
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 11, 2017
@pgaskin
Copy link
Contributor

pgaskin commented Apr 11, 2017 •
edited
Loading

LGTM. Tests would be useful as well, but this looks good.

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 11, 2017
appleboy
appleboy reviewed Apr 11, 2017
View reviewed changes
models/migrations/v28.go
@@ -0,0 +1,77 @@
// Copyright 2017 The Gogs Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

porting from Gogs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the migration is straight from Gogs.

@lunny
Copy link
Member

lunny commented Apr 11, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 11, 2017
@appleboy appleboy merged commit be6edad into go-gitea:master Apr 11, 2017
@appleboy appleboy mentioned this pull request Apr 11, 2017
Closed
@cez81 cez81 deleted the repo_size branch April 11, 2017 16:04
@DblK
Copy link
Member

DblK commented May 4, 2017

Thanks for your work I didn't find free time to finish it.

@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy left review comments

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cez81 @pgaskin @lunny @DblK @appleboy @tboerger