Organization removal confirmation using name not password

[pboguslawski]

Gitea is asking for user password to confirm organization
removal so this operation cannot be done in systems with
SSO authentication (where no user passwords are used).

This mod changes the way gitea confirms organization
removal - user must enter organization name (not user
password) to confirm operation (similar to repository
removal confirmation).

Author-Change-Id: IB#1107219

[Kreyren]

FWIW i prefer the password way in scenarios where I might leave my system unattended (which rarely happens but i like safe-failure)

.. and i prefer the password over name as on GitHub it wastes time assuming password manager filling the password for me.

Proposing to implement this as a configuration per repository instead.

[pboguslawski]

FWIW i prefer the password way in scenarios where I might leave my system unattended (which rarely happens but i like safe-failure)

This PR is not a nice to have feature but bugfix - without it gitea does not allow to remove organization when SSO is used without password (i.e. with reverse proxy auth only scenario).

If you feel afraid of org removal accidentally then use account without access to org settings - messing with passwords in SSO scenarios seems not practical.

[pboguslawski]

Proposing to implement this as a configuration per repository instead

This PR does not apply to repo removal but org removal. Gitea confirms repo removal using its name so its compatible with both password and SSO auth.

[Kreyren]

This PR is not a nice to have feature but bugfix - without it gitea does not allow to remove organization when SSO is used without password (i.e. with reverse proxy auth only scenario).

Noted

---

This PR does not apply to repo removal but org removal. Gitea confirms repo removal using its name so its compatible with both password and SSO auth.

My fault then! I guess i confused it with the org removal, would still argue for this to be a configurable option for org and repo.

[6543]

@pboguslawski pleace merge master into?

Since your fork is within a org github, it do not allow us maintainer to keep your feature branch up to date to merge ...

[pboguslawski]

pleace merge master into?

Just pressed "Update branch" on this PR page.