-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Gitea version in swagger #14654
Conversation
Won't the API version need to evolve separately from the Gitea version? For obtaining the Gitea version through the API there is https://try.gitea.io/api/v1/version. |
well it's only to generate swagger docs ... at the moment it is useless and i think it's save to use gitea's version to version the swagger json with it ... |
@techknowlogick now it looks good, we just have to replace |
If it's only for documentation purposes then I would suggest |
we did not evolve API and Gitea independently (We do not backport api features) |
From security perspective it should be show only if allowed by setting to show version number |
@lafriks app version is visible many places elsewhere in app, such as the MD5 for cache busting of JS & CSS assets |
🚀 |
Fix #14645