Add option for administrator to reset user 2FA

[6543]

by checking the "Reset 2FA" checkbox the 2fa is reset if exist ...

[CirnoT]

I don't think this removes U2F registrations, leaving 2FA in a rather inconsistent state where U2F tokens are registered but 2FA itself is disabled.

[6543]

@CirnoT this is the way it is done ... :

gitea/routers/user/setting/security_twofa.go

Lines 55 to 82 in 3d38ecb

	// DisableTwoFactor deletes the user's 2FA settings.
	func DisableTwoFactor(ctx *context.Context) {
	ctx.Data["Title"] = ctx.Tr("settings")
	ctx.Data["PageIsSettingsSecurity"] = true
	t, err := models.GetTwoFactorByUID(ctx.User.ID)
	if err != nil {
	if models.IsErrTwoFactorNotEnrolled(err) {
	ctx.Flash.Error(ctx.Tr("setting.twofa_not_enrolled"))
	ctx.Redirect(setting.AppSubURL + "/user/settings/security")
	}
	ctx.ServerError("SettingsTwoFactor: Failed to GetTwoFactorByUID", err)
	return
	}
	if err = models.DeleteTwoFactorByID(t.ID, ctx.User.ID); err != nil {
	if models.IsErrTwoFactorNotEnrolled(err) {
	// There is a potential DB race here - we must have been disabled by another request in the intervening period
	ctx.Flash.Success(ctx.Tr("settings.twofa_disabled"))
	ctx.Redirect(setting.AppSubURL + "/user/settings/security")
	}
	ctx.ServerError("SettingsTwoFactor: Failed to DeleteTwoFactorByID", err)
	return
	}
	ctx.Flash.Success(ctx.Tr("settings.twofa_disabled"))
	ctx.Redirect(setting.AppSubURL + "/user/settings/security")
	}

for the admin pannel, this is just simplified as it dont need to be that verbose there (fail or sucess and move forward with other changes)

[CirnoT]

I still really think U2F registrations should be removed when 2FA is disabled administratively.

On the other hand, maybe they can be also used for other things later on. Won't block because of that.

[6543]

@CirnoT done -> 42e7d84

[codecov-io]

Codecov Report

Merging #14243 (42e7d84) into master (8db0372) will decrease coverage by 0.00%.
The diff coverage is 26.66%.

@@            Coverage Diff             @@
##           master   #14243      +/-   ##
==========================================
- Coverage   41.97%   41.96%   -0.01%     
==========================================
  Files         735      735              
  Lines       78933    78948      +15     
==========================================
+ Hits        33130    33132       +2     
- Misses      40347    40358      +11     
- Partials     5456     5458       +2     

Impacted Files	Coverage Δ
modules/auth/admin.go	0.00% <ø> (ø)
routers/admin/users.go	27.77% <26.66%> (-0.08%)	⬇️
modules/indexer/stats/db.go	48.00% <0.00%> (-12.00%)	⬇️
modules/git/repo_commit_nogogit.go	63.33% <0.00%> (-1.67%)	⬇️
services/pull/pull.go	42.28% <0.00%> (-0.50%)	⬇️
modules/log/event.go	59.90% <0.00%> (+0.94%)	⬆️
modules/log/file.go	75.20% <0.00%> (+1.60%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8db0372...42e7d84. Read the comment docs.

[6543]

🚀