Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing username on dashboard context switch navbar #13959

Merged
merged 2 commits into from
Dec 12, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Dec 12, 2020

Fix missing username on dashboard context switch navbar

Introduced by #13649

chrome_2020-12-12_02-01-17

@lunny lunny added the type/bug label Dec 12, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 12, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 12, 2020
@6543 6543 added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Dec 12, 2020
@6543 6543 added this to the 1.14.0 milestone Dec 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #13959 (19e4e07) into master (1837e64) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13959      +/-   ##
==========================================
- Coverage   42.25%   42.12%   -0.13%     
==========================================
  Files         710      710              
  Lines       77226    77228       +2     
==========================================
- Hits        32628    32530      -98     
- Misses      39235    39346     +111     
+ Partials     5363     5352      -11     
Impacted Files Coverage Δ
services/wiki/wiki.go 57.94% <0.00%> (-0.61%) ⬇️
modules/notification/ui/ui.go 84.72% <0.00%> (-11.12%) ⬇️
models/issue_comment.go 45.46% <0.00%> (-7.26%) ⬇️
modules/queue/unique_queue_channel.go 58.06% <0.00%> (-6.46%) ⬇️
modules/notification/mail/mail.go 33.33% <0.00%> (-5.75%) ⬇️
modules/git/commit.go 49.67% <0.00%> (-3.95%) ⬇️
modules/notification/base/null.go 74.28% <0.00%> (-2.86%) ⬇️
modules/notification/notification.go 83.92% <0.00%> (-2.68%) ⬇️
modules/charset/charset.go 68.53% <0.00%> (-2.25%) ⬇️
services/gitdiff/gitdiff.go 69.05% <0.00%> (-1.94%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e9a3d...19e4e07. Read the comment docs.

@6543 6543 merged commit 6074e13 into go-gitea:master Dec 12, 2020
@CirnoT CirnoT deleted the navbar-username branch December 12, 2020 17:34
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants