Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send error message when CSRF token is missing #13676

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Conversation

kevinzg
Copy link
Contributor

@kevinzg kevinzg commented Nov 23, 2020

I was having the problem described in #13484. It turns out the 401 response was because the CSRF token was missing. This PR adds an error message for that case.

@codecov-io
Copy link

Codecov Report

Merging #13676 (4fe455b) into master (2791cc1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #13676   +/-   ##
=======================================
  Coverage   42.25%   42.25%           
=======================================
  Files         697      697           
  Lines       76596    76596           
=======================================
+ Hits        32363    32368    +5     
+ Misses      38919    38913    -6     
- Partials     5314     5315    +1     
Impacted Files Coverage Δ
modules/context/api.go 70.00% <100.00%> (ø)
modules/queue/manager.go 62.13% <0.00%> (-2.96%) ⬇️
models/unit.go 46.57% <0.00%> (-2.74%) ⬇️
modules/queue/unique_queue_disk_channel.go 53.84% <0.00%> (-1.54%) ⬇️
routers/api/v1/repo/pull.go 24.84% <0.00%> (-0.61%) ⬇️
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
services/pull/patch.go 55.68% <0.00%> (+1.70%) ⬆️
services/pull/check.go 51.82% <0.00%> (+2.91%) ⬆️
services/pull/temp_repo.go 29.78% <0.00%> (+3.19%) ⬆️
modules/charset/charset.go 73.03% <0.00%> (+4.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2791cc1...4fe455b. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 23, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 23, 2020
@lafriks lafriks added the modifies/api This PR adds API routes or modifies them label Nov 23, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 23, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 23, 2020
@zeripath zeripath merged commit 247ab6a into go-gitea:master Nov 23, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants