Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fetch request from heatmap #13623

Merged
merged 8 commits into from
Nov 18, 2020
Merged

Remove fetch request from heatmap #13623

merged 8 commits into from
Nov 18, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 18, 2020 •
edited
Loading

Render heatmap data directly to HTML, eliminating one HTTP request on frontpage and user profile. Also added min-height to the container so the page content will no longer move after loading.

@silverwind
Remove fetch request from heatmap
24bf247 
Render heatmap data directly to HTML, eliminating one HTTP request on
frontpage and user profile. Also added min-height to the container so
the page content will no longer move after loading.
jolheiser
jolheiser reviewed Nov 18, 2020
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 18, 2020
@jolheiser jolheiser added the type/enhancement An improvement of existing functionality label Nov 18, 2020
@jolheiser jolheiser added this to the 1.14.0 milestone Nov 18, 2020
6543
6543 approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like it & works as it should

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 18, 2020
jolheiser
jolheiser requested changes Nov 18, 2020
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting nit

silverwind and others added 2 commits November 18, 2020 21:32
@silverwind @jolheiser
Update routers/user/home.go
6be4db7 
Co-authored-by: John Olheiser <[email protected]>
@silverwind @jolheiser
Update routers/user/profile.go
bc2cd4a 
Co-authored-by: John Olheiser <[email protected]>
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 18, 2020
@6543
Copy link
Member

6543 commented Nov 18, 2020

🚀

@jolheiser jolheiser merged commit 12c2efb into go-gitea:master Nov 18, 2020
@silverwind silverwind deleted the heatmap-initial branch November 18, 2020 22:39
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf added a commit to wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf/gitea that referenced this pull request Nov 19, 2020
@wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
fix: show dashboard heatmap in full size
3cb6c58 
* issue introduced by go-gitea#13623 makes the heatmap to show up really small
Closed
4 tasks
@6543 6543 mentioned this pull request Nov 19, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @6543 @jolheiser @GiteaBot