Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework focused comment styling #13434

Merged
merged 1 commit into from
Nov 5, 2020
Merged

Rework focused comment styling #13434

merged 1 commit into from
Nov 5, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Nov 5, 2020 •
edited
Loading

Had to tweak a few borders to make it work properly in all cases, also added .comment-body class to specifically target that body.

Screen Shot 2020-11-05 at 19 47 20

Screen Shot 2020-11-05 at 19 47 30

Screen Shot 2020-11-05 at 19 47 57

Screen Shot 2020-11-05 at 19 48 08

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 5, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Nov 5, 2020
@lafriks lafriks added this to the 1.14.0 milestone Nov 5, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 5, 2020
@silverwind
Rework focused comment styling
2d81ee4 
Had to tweak a few borders to make it work properly in all cases, also
added .comment-body class to specifically target that body.
@lafriks
Copy link
Member

lafriks commented Nov 5, 2020

🚀

@lafriks lafriks merged commit eba0ac5 into go-gitea:master Nov 5, 2020
@silverwind silverwind deleted the hashfocus branch November 5, 2020 19:35
CirnoT added a commit to CirnoT/gitea that referenced this pull request Nov 7, 2020
@CirnoT
Fix double border introduced by go-gitea#13434
e56b508
@CirnoT CirnoT mentioned this pull request Nov 7, 2020
Merged
techknowlogick added a commit that referenced this pull request Nov 7, 2020
@CirnoT @techknowlogick @zeripath
Fix double border introduced by #13434 (#13457)
f719e2e 
Co-authored-by: techknowlogick <[email protected]>
Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @lafriks @mrsdizzie @GiteaBot