Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better oauth2 button and make horizontal navbar scroll on overflow #1300

Closed
wants to merge 9 commits into from
Closed

Conversation

pgaskin
Copy link
Contributor

@pgaskin pgaskin commented Mar 17, 2017

Better oauth2 button and make horizontal navbar scroll on overflow

login

scrolling

@strk
Copy link
Member

strk commented Mar 17, 2017

LGTM but I'd like to see it in action to check how it behaves upon resizing the browser window

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 17, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 17, 2017

@strk I will add it to my server and fyi it will put the scrollbar the moment there is an overflow.

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 17, 2017

@strk
Copy link
Member

strk commented Mar 17, 2017

Ok now I see it. The scrollbar kicks in too late so I can handle to have a view with truncated labels rather than a scrollbar.

Attaching screenshot:
navbar

@strk
Copy link
Member

strk commented Mar 17, 2017

btw, maybe it would be good to rename Email Addresses to Email and Two-Factor Authentication to 2FA (not sure about this)

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 17, 2017

@strk I'll rename that in another PR. I have updated my server with the bugfixes.

@lunny lunny added this to the 1.2.0 milestone Mar 17, 2017
@lunny lunny added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Mar 17, 2017
@strk
Copy link
Member

strk commented Mar 17, 2017

Better, thank you.

@strk
Copy link
Member

strk commented Mar 17, 2017

I just spotted this overlap in current master, dunno if your branch also fixes this (btw, needs to resolve conflicts)

navbar-overlap

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 17, 2017 via email

@pgaskin
Copy link
Contributor Author

pgaskin commented Mar 17, 2017

@strk I fixed it in #1316

@strk
Copy link
Member

strk commented Mar 18, 2017

Yes @geek1011 it conflicted after the merge of the OpenID branch. Please fix the conflict and rebase.

@Quix0r
Copy link

Quix0r commented Mar 21, 2017

Only templates/user/auth/signin_inner.tmpl is left.

@pgaskin
Copy link
Contributor Author

pgaskin commented Apr 7, 2017

Fixed, sorry about the delay.

@strk
Copy link
Member

strk commented Apr 7, 2017

@appleboy, @lunny can you please review/merge this ?

@lunny
Copy link
Member

lunny commented Apr 8, 2017

@strk @geek1011 this will conflict with #1010

@strk
Copy link
Member

strk commented Apr 8, 2017

@lunny you found #1010 broken while this is ready, let's merge this and let conflicts be resolved in #1010

@lunny
Copy link
Member

lunny commented Apr 8, 2017

Is this ready to review?

@pgaskin
Copy link
Contributor Author

pgaskin commented Apr 8, 2017

Yes

@lunny
Copy link
Member

lunny commented Apr 8, 2017

chrome on mac the github login button is not center.
untitled

@lunny
Copy link
Member

lunny commented May 20, 2017

any news?

@pgaskin
Copy link
Contributor Author

pgaskin commented May 22, 2017

I'm closing this PR, I will rewrite it with a better design because this is conflicted and will not look good with more than 2 providers.

@pgaskin pgaskin closed this May 22, 2017
@pgaskin
Copy link
Contributor Author

pgaskin commented May 22, 2017

@lunny #1777

@pgaskin pgaskin deleted the patch-2 branch May 24, 2017 01:05
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants