-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better oauth2 button and make horizontal navbar scroll on overflow #1300
Conversation
LGTM but I'd like to see it in action to check how it behaves upon resizing the browser window |
@strk I will add it to my server and fyi it will put the scrollbar the moment there is an overflow. |
btw, maybe it would be good to rename |
@strk I'll rename that in another PR. I have updated my server with the bugfixes. |
Better, thank you. |
I think your merge did that because it was fine before.
|
Yes @geek1011 it conflicted after the merge of the OpenID branch. Please fix the conflict and rebase. |
Only |
Fixed, sorry about the delay. |
Is this ready to review? |
Yes |
any news? |
I'm closing this PR, I will rewrite it with a better design because this is conflicted and will not look good with more than 2 providers. |
Better oauth2 button and make horizontal navbar scroll on overflow