Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more toned colors for selected line #11493

Merged
merged 2 commits into from
May 19, 2020
Merged

Use more toned colors for selected line #11493

merged 2 commits into from
May 19, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 18, 2020

chrome_2020-05-18_22-06-16

@lafriks
Copy link
Member

lafriks commented May 18, 2020 •
edited
Loading

How does it look in dark theme? edit: there is already PR for this

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 18, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 18, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 18, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 18, 2020
@CirnoT
Copy link
Contributor Author

CirnoT commented May 18, 2020 •
edited
Loading

@lafriks It's very subtle change for arc-green; not that the older color was ever used properly in arc-green to begin with, so...

After:
chrome_2020-05-18_22-27-57

Before (if the color worked):
chrome_2020-05-18_22-30-00

@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 7b66400 into go-gitea:master May 19, 2020
@lafriks
Copy link
Member

lafriks commented May 19, 2020

please send backport

@CirnoT CirnoT deleted the selected_line-color branch May 19, 2020 12:45
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 19, 2020
@CirnoT
Use more toned colors for selected line (go-gitea#11493)
c1f4587 
Co-authored-by: zeripath <[email protected]>
(cherry picked from commit 7b66400)
@CirnoT CirnoT mentioned this pull request May 19, 2020
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 19, 2020
techknowlogick added a commit that referenced this pull request May 20, 2020
@CirnoT @techknowlogick
Use more toned colors for selected line (#11493) (#11511)
b67eafb 
Co-authored-by: zeripath <[email protected]>
(cherry picked from commit 7b66400)

Co-authored-by: techknowlogick <[email protected]>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@CirnoT @zeripath
Use more toned colors for selected line (go-gitea#11493)
02f2ee3 
Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@CirnoT @lafriks @techknowlogick @jolheiser @GiteaBot @zeripath