Add Get/Update for api/v1/user/applications/oauth2 #11008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
reviewed
Apr 7, 2020
GiteaBot
added
the
lgtm/need 2
|
Had some fixups with registering the new endpoints and passing the tests. |
|
looks like an unrelated postgres logging error |
|
@dmolik pleace read the Contributing Guidline for API: https://github.com/go-gitea/gitea/blob/master/CONTRIBUTING.md#api-v1 |
6543
requested changes
Apr 7, 2020
|
@dmolik If you do not forcepush it's easier to review (pull get squash-merged at the end) |
6543
reviewed
Apr 7, 2020
6543
approved these changes
Apr 8, 2020
GiteaBot
added
lgtm/need 1
|
Note for me: if merged, prepare UpdateOAuth2Application to return the app result back and handle errors |
lafriks
approved these changes
Apr 8, 2020
GiteaBot
added
lgtm/done
lafriks
added
modifies/api
|
Okie dokie, I went ahead and squashed the commits |
|
Looks like there were some mysql and mssql test failures, unrelated to this change. |
6543
approved these changes
Apr 8, 2020
Add api methods for getting and updating user oauth2 applications. Signed-off-by: Dan Molik <[email protected]>
|
@6543 sweet the build passed! want to give it a once over? |
|
Ping lgtm |
|
created refactor #11034 |
zeripath
pushed a commit
that referenced
this pull request
Apr 30, 2020
Following on from #11008 refactor UpdateOAuth2Application
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Add api methods for getting and updating user oauth2 applications. Signed-off-by: Dan Molik <[email protected]> Co-authored-by: techknowlogick <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
Following on from go-gitea#11008 refactor UpdateOAuth2Application
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API methods for getting and updating user oauth2 applications.