Add an option to disallow commiters to approve pull request

[MarkusAmshove]

If there are multiple people committing into a branch which is then used as a source for a pull request it is currently possible for reviewers, who also committed, to approve the changes.

I think it would be valuable if the branch protection had a setting to disallow approval by commiters within the PR, as it is currently the default to disallow approval by the PR author.

[lunny]

This has been implemented in branch protection UI to just allow who can approve.

[MarkusAmshove]

Is this for 1.9? I can't find a changelog.
We're on 1.8 and if I'm a configured approver (in branch protection) but I did commits to the PR of someone else, I can still approve it

[lunny]

Did you mean the author of a pull request should not approve himself?

[MarkusAmshove]

Repository at try.gitea.io: https://try.gitea.io/prauthor/ApprovalTest

The user PRAuthor is the owner of the repository (password is same as name, all lower case).

Scenario:
PRContrib does some changes in a branch and pushes the branch upstream, while also creating a PR.
Now PRContrib and PRAuthor work together in pair programming at PRAuthors computer.
The commits of the PR now also have a commit of the owner of the repository.
PRAuthor can still approve the changes and merge the PR, as he is in the approvers list.

What I expect in this scenario, is that PRAuthor can't approve the PR and a third person has to do the review.
This would result in the same behavior as it currently is when PRAuthor would have created the PR (can't review your own).

So just to be clear: PRAuthor shouldn't be allowed to approve the PR now :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[informeti]

It seems this is still an existing issue in 1.17.1 and I couldn't find any way to configure the behavior.

GitHub, for instance, handles this correctly: Neither the committer, nor the co-author(s) can approve the PR.

[lunny]

It seems this is still an existing issue in 1.17.1 and I couldn't find any way to configure the behavior.

GitHub, for instance, handles this correctly: Neither the committer, nor the co-author(s) can approve the PR.

I don't think Github has the behaviour. Only pull request poster cannot approve the PR. Other committers can approve the pull request.