Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot delete branch with slash in name after PR #1397

Closed
2 of 7 tasks
Aarup opened this issue Mar 28, 2017 · 1 comment · Fixed by #1994
Closed
2 of 7 tasks

Cannot delete branch with slash in name after PR #1397

Aarup opened this issue Mar 28, 2017 · 1 comment · Fixed by #1994
Labels
type/bug
Milestone
1.2.0

Comments

@Aarup
Copy link

Aarup commented Mar 28, 2017 •
edited
Loading

Description

If a branch has has a slash in the name like

  • bug/bugsId
  • feature/featureName
    It is impossible to delete this branch using the web UI after a PR has been merged into the repository.
    When clicking the "Delete branch" button a generic popup comes, but after entering username and password nothing happens - a 404 is received from the post

Screenshots

image
image
@lunny lunny added the type/bug label Mar 28, 2017
@lunny lunny added this to the 1.2.0 milestone Mar 28, 2017
@lunny lunny mentioned this issue May 8, 2017
Closed
@lunny
Copy link
Member

lunny commented May 8, 2017

#1689, it seems Gitea has a different URL with github's URL on this feature.

@lafriks lafriks mentioned this issue Jun 17, 2017
Merged
lafriks added a commit to lafriks-fork/gitea that referenced this issue Jun 19, 2017
@lafriks
Make branch deletion URL more like GitHub's, fixes go-gitea#1397
bede0e2
lunny pushed a commit that referenced this issue Jun 21, 2017
@lafriks @lunny
Make branch deletion URL more like GitHub's, fixes #1397 (#1994)
0a5dc64 
* Make branch deletion URL more like GitHub's, fixes #1397

* Add PR branch deletion integration test

* Do not allow deleting protected branch

* Change http error code to 403 if user has no write rights to repository

* Add check to not panic if forked repository has alrady been deleted
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.2.0
2 participants
@lunny @Aarup