Harmonize integrity checkers

packages/app/app/api/permissions/route.ts

@@ -1,5 +1,5 @@
 import { NextResponse } from "next/server"
-import { checkIntegrity } from "zodiac-roles-sdk"
+import { targetIntegrity } from "zodiac-roles-sdk"
 import { kv } from "@vercel/kv"
 import { createHash } from "crypto"
 import { PermissionsPost, zPermissionsPost } from "./types"
@@ -18,7 +18,7 @@ export async function POST(req: Request) {
 
   if (validated.targets) {
     try {
-      checkIntegrity(validated.targets)
+      targetIntegrity(validated.targets)
     } catch (e) {
       return NextResponse.json({
         error: "Targets integrity check failed",

packages/app/app/permissions/page.tsx

@@ -5,7 +5,7 @@ import { useRouter } from "next/navigation"
 import {
   Annotation,
   Target,
-  checkIntegrity,
+  targetIntegrity,
   processPermissions,
 } from "zodiac-roles-sdk"
 import styles from "./page.module.css"
@@ -76,7 +76,7 @@ export default function PermissionsPage() {
 
   if (targets) {
     try {
-      checkIntegrity(targets)
+      targetIntegrity(targets)
     } catch (e) {
       errorMessage =
         e instanceof Error

packages/sdk/src/main/index.ts

@@ -7,6 +7,7 @@ export * from "zodiac-roles-deployments"
  */
 export { c, forAll } from "./target/authoring"
 export { planApply, planApplyRole, planExtendRole } from "./target/plan"
+export { default as targetIntegrity } from "./target/integrity"
 
 /*
  *

packages/sdk/src/main/target/authoring/c/matches.ts

@@ -2,7 +2,7 @@ import { BigNumberish, isHexString, ParamType } from "ethers"
 import { Condition, Operator, ParameterType } from "zodiac-roles-deployments"
 
 import { coercePermission } from "../../../permission/coercePermission"
-import { checkParameterTypeCompatibility } from "../../condition/checkConditionIntegrity"
+import { checkParameterTypeCompatibility } from "../../condition/conditionIntegrity"
 import { describeStructure } from "../helpers/describeStructure"
 import { parameterType } from "../helpers/parameterType"
 

packages/sdk/src/main/target/condition/checkConditionIntegrity.test.ts → packages/sdk/src/main/target/condition/conditionIntegrity.test.ts

@@ -4,7 +4,7 @@ import { Operator, ParameterType } from "zodiac-roles-deployments"
 import {
   checkConditionIntegrity,
   checkRootConditionIntegrity,
-} from "./checkConditionIntegrity"
+} from "./conditionIntegrity"
 import { abiEncode } from "../../utils/abiEncode"
 
 suite("checkConditionIntegrity()", () => {

packages/sdk/src/main/target/condition/checkConditionIntegrity.ts → packages/sdk/src/main/target/condition/conditionIntegrity.ts

@@ -1,10 +1,5 @@
 import { Condition, Operator, ParameterType } from "zodiac-roles-deployments"
 
-export const checkConditionIntegrity = (condition: Condition): void => {
-  checkConsistentChildrenTypes(condition)
-  checkConditionIntegrityRecursive(condition)
-}
-
 export const checkRootConditionIntegrity = (condition: Condition): void => {
   const rootType = checkConsistentChildrenTypes(condition)
   if (rootType !== ParameterType.Calldata) {
@@ -15,6 +10,11 @@ export const checkRootConditionIntegrity = (condition: Condition): void => {
   checkConditionIntegrityRecursive(condition)
 }
 
+export const checkConditionIntegrity = (condition: Condition): void => {
+  checkConsistentChildrenTypes(condition)
+  checkConditionIntegrityRecursive(condition)
+}
+
 /**
  * Validates that logical condition children have consistent types.
  * Since the children conditions address the very same value it does not make sense for them to declare incompatible param types.

packages/sdk/src/main/utils/targetIntegrity.ts → packages/sdk/src/main/target/integrity.ts

@@ -1,19 +1,19 @@
 import { Clearance, Function, Target } from "zodiac-roles-deployments"
 
-import { checkRootConditionIntegrity } from "../target/condition/checkConditionIntegrity"
+import { checkRootConditionIntegrity } from "./condition/conditionIntegrity"
 
-export const checkIntegrity = (targets: Target[]): void => {
+export default (targets: Target[]): void => {
   const uniqueAddresses = new Set(
     targets.map((target) => target.address.toLowerCase())
   )
   if (uniqueAddresses.size < targets.length) {
     throw new Error("Duplicate target addresses")
   }
 
-  targets.forEach(checkTargetIntegrity)
+  targets.forEach(targetIntegrity)
 }
 
-const checkTargetIntegrity = (target: Target): void => {
+const targetIntegrity = (target: Target): void => {
   if (
     target.clearance === Clearance.Function &&
     target.functions.length === 0
@@ -36,10 +36,10 @@ const checkTargetIntegrity = (target: Target): void => {
     throw new Error(`Duplicate functions in target ${target.address}`)
   }
 
-  target.functions.forEach(checkFunctionIntegrity)
+  target.functions.forEach(functionIntegrity)
 }
 
-const checkFunctionIntegrity = (func: Function): void => {
+const functionIntegrity = (func: Function): void => {
   if (func.wildcarded && func.condition) {
     throw new Error(
       `Wildcarded functions cannot have conditions (function in violation: ${func.selector})`