Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): move r/demo/markdown_test to r/docs/markdown + update content #3909

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

moul
Copy link
Member

@moul moul commented Mar 11, 2025

once merged, we should take the habit of updating it when we extend gnoweb's rendering capabilities such as in #3763

@moul moul self-assigned this Mar 11, 2025
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 11, 2025
@moul moul changed the title dev/moul/docs md chore(examples): move r/demo/markdown_test to r/docs/markdown + update content Mar 11, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 11, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@moul
Copy link
Member Author

moul commented Mar 11, 2025

screencapture-localhost-8888-r-docs-markdown-2025-03-11-11_06_19

func Render(_ string) string {
content := ""
content += frontMatter()
content += frontMatter() // XXX: try to remove this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #3910

@moul moul merged commit 6b6bbd3 into gnolang:master Mar 11, 2025
79 of 80 checks passed
@moul moul deleted the dev/moul/docs-md branch March 11, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants