Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WIP): gnoland home realm #3888

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

alexiscolin
Copy link
Member

@alexiscolin alexiscolin commented Mar 7, 2025

Related to #3249, This PR init the refactor of the gno.land homepage, focusing on content sections and design.

Related: Figma design file.

TODO:

  • Columns are implemented in code but require feat(gnoweb): Add gno-columns extension #3763 to be merged in order to appear in the UI.
  • Images need to be added to the assets folder (WIP).
  • Finalized content must be added.
  •  Once Columns component is merged, we should add a new Input component to manage the airdrop tracker.
  • Add meta title and description

⚠️ Work in progress (WIP) with placeholder text, and the correct content still needs to be provided by the relevant counterparts in this PR.

@alexiscolin alexiscolin marked this pull request as draft March 7, 2025 06:04
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Mar 7, 2025
@alexiscolin alexiscolin requested a review from leohhhn March 7, 2025 06:05
@Gno2D2 Gno2D2 requested a review from a team March 7, 2025 06:05
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 7, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Pending initial approval by a review team member, or review from tech-staff

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: alexiscolin/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Pending initial approval by a review team member, or review from tech-staff

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 Not (🔴 Pull request author is a member of the team: tech-staff)

Then

🟢 Requirement satisfied
└── 🟢 If
    ├── 🟢 Condition
    │   └── 🟢 Or
    │       ├── 🔴 At least 1 user(s) of the organization reviewed the pull request (with state "APPROVED")
    │       ├── 🟢 At least 1 user(s) of the team tech-staff reviewed pull request
    │       └── 🟢 This pull request is a draft
    └── 🟢 Then
        └── 🟢 Not (🔴 This label is applied to pull request: review/triage-pending)

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@alexiscolin
Copy link
Member Author

alexiscolin commented Mar 7, 2025

@leohhhn, should we consider an alternative method to AdminSetOverride for updating content, with future scalability in mind?

@alexiscolin
Copy link
Member Author

@leohhhn, should we consider an alternative method to AdminSetOverride for updating content, with future scalability in mind?

I guess it should be ok, since Manfred updated the realm one week ago with this feature.

Proposed suggestions for content for the homepage to be reviewed and iterated upon.
@zivkovicmilos zivkovicmilos requested review from moul and zivkovicmilos and removed request for a team March 10, 2025 17:57
Comment on lines -33 to -39
r.RegisterCallback(":latest-hof:", func() string {
return hof.RenderExhibWidget(5)
})
r.RegisterCallback(":qotb:", quoteOfTheBlock)
r.RegisterCallback(":chain-height:", func() string {
return strconv.Itoa(int(std.ChainHeight()))
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should not remove these things, they are about allowing to have dynamic content on the homepage which is a target.

ps: you should also use some of them in the template code.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul We plan to use them (dynamic parts) for other purpose (roadmap for ex).

We’re building gno.land, set to become the leading open-source smart contract
platform, using Gno, an interpreted and fully deterministic variation of the
Go programming language for succinct and composable smart contracts.
## We're building a user-owned internet where governance is fair, development is open, and innovation is rewarded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not use H2 just to make text bigger.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a good idea to use it as an H2 for SEO purposes (not for text size).

:latest-hof:
</gno-columns>

TODO: Add 'Beta Mainnet Coming Soon!' section
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leohhhn can you make this dynamic, i.e., by having like r/gnoland/blog to have a "news" tag?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moul OK, that's what I wrote above about the dynamic sections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: No status
Status: Triage
Development

Successfully merging this pull request may close these issues.

5 participants