-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(WIP): gnoland home realm #3888
base: master
Are you sure you want to change the base?
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
@leohhhn, should we consider an alternative method to AdminSetOverride for updating content, with future scalability in mind? |
I guess it should be ok, since Manfred updated the realm one week ago with this feature. |
Proposed suggestions for content for the homepage to be reviewed and iterated upon.
r.RegisterCallback(":latest-hof:", func() string { | ||
return hof.RenderExhibWidget(5) | ||
}) | ||
r.RegisterCallback(":qotb:", quoteOfTheBlock) | ||
r.RegisterCallback(":chain-height:", func() string { | ||
return strconv.Itoa(int(std.ChainHeight())) | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should not remove these things, they are about allowing to have dynamic content on the homepage which is a target.
ps: you should also use some of them in the template code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moul We plan to use them (dynamic parts) for other purpose (roadmap for ex).
We’re building gno.land, set to become the leading open-source smart contract | ||
platform, using Gno, an interpreted and fully deterministic variation of the | ||
Go programming language for succinct and composable smart contracts. | ||
## We're building a user-owned internet where governance is fair, development is open, and innovation is rewarded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not use H2 just to make text bigger.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to use it as an H2 for SEO purposes (not for text size).
:latest-hof: | ||
</gno-columns> | ||
|
||
TODO: Add 'Beta Mainnet Coming Soon!' section |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leohhhn can you make this dynamic, i.e., by having like r/gnoland/blog to have a "news" tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moul OK, that's what I wrote above about the dynamic sections
Co-authored-by: Manfred Touron <[email protected]>
Related to #3249, This PR init the refactor of the gno.land homepage, focusing on content sections and design.
Related: Figma design file.
TODO:
Columns
component is merged, we should add a newInput
component to manage the airdrop tracker.