Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd/gno): perform type checking before test #3887

Merged
merged 5 commits into from
Mar 10, 2025

Conversation

thehowl
Copy link
Member

@thehowl thehowl commented Mar 7, 2025

Fixes #3831.

Adds type checking as a step before executing a package's tests.

@thehowl thehowl self-assigned this Mar 7, 2025
@github-actions github-actions bot added the 📦 🤖 gnovm Issues or PRs gnovm related label Mar 7, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Mar 7, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: thehowl/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
gnovm/cmd/gno/test.go 63.63% 2 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@thehowl thehowl merged commit 4608777 into gnolang:master Mar 10, 2025
19 checks passed
@thehowl thehowl deleted the dev/morgan/typecheck-before-test branch March 10, 2025 15:35
Villaquiranm pushed a commit to Villaquiranm/gno that referenced this pull request Mar 11, 2025
Fixes gnolang#3831.

Adds type checking as a step before executing a package's tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[GnoVM] Execute type checker before gno test
3 participants