-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fmt #3578
chore: fmt #3578
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Signed-off-by: moul <[email protected]>
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Signed-off-by: moul <[email protected]>
#3584 seems to be a better alternative. |
Signed-off-by: moul <[email protected]>
Ready for review. |
make -C ./pkg/gnoweb generate | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover?
@@ -23,7 +23,8 @@ jobs: | |||
- name: Check generated files are up to date | |||
working-directory: ${{ inputs.modulepath }} | |||
run: | | |||
go generate -x ./... | |||
make generate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will fail when being called by at least the following workflows (knowing that main_template
forwards to build_template
):
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really hate that we enforce random makefile directives within subfolders, just to follow a structure (prime example is make lint
, make test
etc)
I can finally run |
Does anyone have the courage to merge while Codecov, our new boss, tells us that we're the weakest thing in the universe? |
whats the issue with the |
@gfanton - This issue arose due to conflicts introduced by recent merges. I simply had to run "make generate" again, which confirms that the CI is functioning properly. Except for Codecov (I'm really frustrated by BS-driven development). |
- fixes problems i introduced in #3578. - 15ff464 - fixes https://github.com/gnolang/gno/actions/runs/13222603746/job/36909546479?pr=3700. - b9fee17 - fixes `red` master.] --------- Signed-off-by: moul <[email protected]>
for the context, i was trying to fix these unrelated PR diffs: https://github.com/gnolang/gno/pull/3176/files#diff-adbe9861bf11ff27b97aafd5a5e8bbe30dca0474c3008cd066f7fd8863b8b3d0L1, then I noticed #3577.
This PR:
make generate
will also format the generated filescd gnovm; make imports
#3577