Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fmt #3578

Merged
merged 11 commits into from
Feb 9, 2025
Merged

chore: fmt #3578

merged 11 commits into from
Feb 9, 2025

Conversation

moul
Copy link
Member

@moul moul commented Jan 21, 2025

for the context, i was trying to fix these unrelated PR diffs: https://github.com/gnolang/gno/pull/3176/files#diff-adbe9861bf11ff27b97aafd5a5e8bbe30dca0474c3008cd066f7fd8863b8b3d0L1, then I noticed #3577.

This PR:

@moul moul self-assigned this Jan 21, 2025
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Jan 21, 2025
@Gno2D2
Copy link
Collaborator

Gno2D2 commented Jan 21, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: moul/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jan 21, 2025
Signed-off-by: moul <[email protected]>
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
tm2/pkg/overflow/overflow_impl.go 50.00% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review January 21, 2025 21:20
@moul
Copy link
Member Author

moul commented Jan 22, 2025

#3584 seems to be a better alternative.

@thehowl
Copy link
Member

thehowl commented Jan 23, 2025

shall we close this in favour of #3584? I don't think this PR is fixing the issue in #3577, at least in its current state.

@moul moul marked this pull request as draft January 24, 2025 14:47
@moul moul marked this pull request as ready for review January 28, 2025 12:27
@moul
Copy link
Member Author

moul commented Jan 28, 2025

Ready for review.

@moul
Copy link
Member Author

moul commented Jan 28, 2025

BTW; can we remove Codecov?

image

@Kouteki Kouteki removed the in focus label Feb 3, 2025
make -C ./pkg/gnoweb generate


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover?

Suggested change

@@ -23,7 +23,8 @@ jobs:
- name: Check generated files are up to date
working-directory: ${{ inputs.modulepath }}
run: |
go generate -x ./...
make generate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hate that we enforce random makefile directives within subfolders, just to follow a structure (prime example is make lint, make test etc)

@zivkovicmilos
Copy link
Member

I can finally run make fmt in peace and not worry it will alter random files

@moul
Copy link
Member Author

moul commented Feb 7, 2025

Does anyone have the courage to merge while Codecov, our new boss, tells us that we're the weakest thing in the universe?

@gfanton
Copy link
Member

gfanton commented Feb 7, 2025

whats the issue with the generated jobs ?

@moul
Copy link
Member Author

moul commented Feb 9, 2025

@gfanton - This issue arose due to conflicts introduced by recent merges. I simply had to run "make generate" again, which confirms that the CI is functioning properly.
5991041 (#3578)

Except for Codecov (I'm really frustrated by BS-driven development).

@moul moul merged commit 52fca76 into gnolang:master Feb 9, 2025
61 of 63 checks passed
@moul moul deleted the dev/moul/fmt branch February 9, 2025 04:28
zivkovicmilos pushed a commit that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

7 participants