Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add r/demo/tests/test20 #2549

Closed
wants to merge 1 commit into from
Closed

Conversation

moul
Copy link
Member

@moul moul commented Jul 8, 2024

Depends on #2551

@moul moul self-assigned this Jul 8, 2024
@github-actions github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Jul 8, 2024
@moul moul marked this pull request as ready for review July 8, 2024 20:18
@moul moul requested review from a team as code owners July 8, 2024 20:18
@moul moul requested review from jaekwon and gfanton and removed request for a team July 8, 2024 20:18
This was referenced Jul 8, 2024
Copy link

github-actions bot commented Nov 7, 2024

This PR is stale because it has been open 3 months with no activity. Remove stale label or comment or this will be closed in 3 months.

@github-actions github-actions bot added the Stale label Nov 7, 2024
@moul moul removed the Stale label Nov 15, 2024
moul added a commit that referenced this pull request Dec 28, 2024
…erplate when using grc20reg (#3397)

- add `r/demo/tests/test20`
- add `grc20.TokenGetter` to reduce boilerplate when using
`grc20reg.Register(...)`

Replaces #2549
Continues #3135

Signed-off-by: moul <[email protected]>
albttx pushed a commit that referenced this pull request Jan 10, 2025
…erplate when using grc20reg (#3397)

- add `r/demo/tests/test20`
- add `grc20.TokenGetter` to reduce boilerplate when using
`grc20reg.Register(...)`

Replaces #2549
Continues #3135

Signed-off-by: moul <[email protected]>
@moul moul closed this in #2510 Jan 20, 2025
moul added a commit that referenced this pull request Jan 20, 2025
- [x] implement
- [x] unit test / txtar
- [x] question: ugnot or grc20 or both? Maybe it’s time to encourage
using `wugnot`.
	**-> both, with a callback mechanism.**
- [x] question: p+r or just r?
	**-> just `r`, and a single file. let's do it more!**
- [x] make the API gnokey compatible + add Render.

Depends on #3397 (cherry-picked)
Depends on #2529 (cherry-picked)
Depends on #2549 (cherry-picked)
Depends on #2551
Closes #2549

---------

Signed-off-by: moul <[email protected]>
Co-authored-by: Leon Hudak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants