Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix <textarea> empty string values #250

Merged
merged 1 commit into from
Aug 3, 2016
Merged

fix <textarea> empty string values #250

merged 1 commit into from
Aug 3, 2016

Conversation

GavinJoyce
Copy link
Contributor

@GavinJoyce GavinJoyce commented Aug 2, 2016

This fixes emberjs/ember.js#14001

Some questions:

  • Are there elements other than <input> and <textarea> that should behave this way?
  • Is there a generic name for input and textarea so that we can give isInputValue a better name? updated to use Godfrey's isUserInputValue suggestion below

@GavinJoyce GavinJoyce changed the title fix textarea empty string values fix <textarea> empty string values Aug 2, 2016
@chancancode
Copy link
Contributor

Maybe isUserInputValue?

@chancancode
Copy link
Contributor

@GavinJoyce this is fine, but it doesn't work on server-side rendering (fastboot). The correct solution is to return a special const TextAreaValueChangeList where:

  • in setAttribute (the "append" pass), create a text node and append it as a child to the <textarea />
  • in updateAttribute (the "update" pass), use the .value property

@GavinJoyce
Copy link
Contributor Author

@chancancode thanks, I'll follow this up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Glimmer 2] textarea renders "true" instead of ""
2 participants