[cleanup]: Remove this. property fallback (e.g. the this-property-fallback deprecation)
#1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
commented
Aug 29, 2021
| op(Op.GetVariable, 0); | ||
| op(Op.GetProperty, name); | ||
| }); | ||
| EXPRESSIONS.add(SexpOpcodes.GetFreeAsFallback, (op, [, , path]) => { | ||
| withPath(op, path); | ||
| }); |
There was a problem hiding this comment.
Should this whole thing be ✂️?
There was a problem hiding this comment.
I can't tell if GetFreeAsFallback also handles the case of an in scope "loose/free" variable. @rwjblue
There was a problem hiding this comment.
@snewcomer - Let's land this as is now, and maybe you can send a follow up PR that removes the GetFreeAsFallback op code and see if all tests pass...
snewcomer
commented
Aug 29, 2021
| @@ -125,7 +125,7 @@ class UpdatingTest extends RenderTest { | |||
|
|
|||
| this.assertHTML(stripTight` | |||
| <div> | |||
| [empty string] | |||
| [] | |||
There was a problem hiding this comment.
this is different behavior. Not sure if technically a regression though. Neither this.[] nor this[''] work.
|
Note - this PR requires #1332 to be merged first. All the failures are in the partials test module. |
snewcomer
force-pushed
the
sn/this-fallback
branch
from
793978e to
8291f84
Compare
rwjblue
changed the title
this. property fallback (e.g. the this-property-fallback deprecation)
snewcomer
force-pushed
the
sn/this-fallback
branch
from
4865e12 to
89adeba
Compare
rwjblue
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes missing
thisdeprecations and supporting code.Ref Ember.js issue: emberjs/ember.js#19617
Ember.js PR: emberjs/ember.js#19736