Skip to content

Remove assert that can fail erroneously. #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2019
Merged

Remove assert that can fail erroneously. #928

merged 1 commit into from
Sep 28, 2019

Conversation

uri-canva
Copy link
Contributor

git will sometimes print out empty progress lines.

@Byron Byron added this to the v3.0.3 - Bugfixes milestone Sep 28, 2019
@Byron
Copy link
Member

Byron commented Sep 28, 2019

Thanks a lot! I also wonder why these empty lines would be an issue, and since there is no test for that, the line might as well be removed.

@Byron Byron merged commit 359a7e0 into gitpython-developers:master Sep 28, 2019
@uri-canva uri-canva deleted the empty-progress branch September 28, 2019 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
v3.0.3 - Bugfixes
Development

Successfully merging this pull request may close these issues.
2 participants
@uri-canva @Byron