Skip to content

Remove windows special handling #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Remove windows special handling #1217

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc90b03
Remove windows special handling
Andor233 Apr 21, 2021
020179b
Update remote.py
Andor233 Apr 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions git/remote.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
import re

from git.cmd import handle_process_output, Git
from git.compat import (defenc, force_text, is_win)
from git.compat import (defenc, force_text)
from git.exc import GitCommandError
from git.util import (
LazyMixin,
Expand Down Expand Up @@ -414,16 +414,6 @@ def __init__(self, repo, name):
self.repo = repo # type: 'Repo'
self.name = name

if is_win:
# some oddity: on windows, python 2.5, it for some reason does not realize
# that it has the config_writer property, but instead calls __getattr__
# which will not yield the expected results. 'pinging' the members
# with a dir call creates the config_writer property that we require
# ... bugs like these make me wonder whether python really wants to be used
# for production. It doesn't happen on linux though.
dir(self)
# END windows special handling

def __getattr__(self, attr):
"""Allows to call this instance like
remote.special( \\*args, \\*\\*kwargs) to call git-remote special self.name"""
Expand Down