Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: continue primer component and design token migration #1749

Merged
merged 10 commits into from
Jan 22, 2025
Merged

feat: continue primer component and design token migration #1749

merged 10 commits into from
Jan 22, 2025

Conversation

setchy
Copy link
Member

@setchy setchy commented Jan 21, 2025 •
edited
Loading

Two main goals in this PR

  • replace almost all tailwind colors with GitHub Primer Design Tokens
  • Use GitHub Theme Provider to control setting light and dark modes
  • ongoing refactor of Gitify UI components to leverage GitHub Primer Components where possible

The only remaining area where we are using .dark classes to control theming is our scrollbar (track, thumb and hover) - left a TODO

@setchy setchy added this to the Release 6.0.0 milestone Jan 21, 2025
@github-actions github-actions bot added dependency Dependency updates enhancement New feature or enhancement to existing functionality labels Jan 21, 2025
@afonsojramos
Copy link
Member

I assume that this PR represents one step towards, but it is not the complete thing yet, right?

@setchy setchy changed the title feat: migrate to primer design tokens feat: continue migration to primer design tokens Jan 21, 2025
@setchy
Copy link
Member Author

setchy commented Jan 21, 2025 •
edited
Loading

I assume that this PR represents one step towards, but it is not the complete thing yet, right?

Good callout, that's correct - a few more steps to fully get there

@setchy setchy marked this pull request as draft January 22, 2025 14:08
@setchy setchy changed the title feat: continue migration to primer design tokens feat: continue primer componet and design token migration Jan 22, 2025
@setchy setchy marked this pull request as ready for review January 22, 2025 16:16
@setchy setchy changed the title feat: continue primer componet and design token migration feat: continue primer component and design token migration Jan 22, 2025
@setchy setchy merged commit 7d93a71 into main Jan 22, 2025
17 checks passed
@setchy setchy deleted the feat/migrate-primer-design-tokens branch January 22, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees
No one assigned
Labels
dependency Dependency updates enhancement New feature or enhancement to existing functionality
Projects
None yet
Milestone
Release 6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @afonsojramos