-
Notifications
You must be signed in to change notification settings - Fork 61.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GitHub with data variable #36757
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsoref, I've also added a missing full stop. I also think that given this is in a reusable, it would be better with an abbreviated linking sentence as in my suggestion, and removing the new blank line between the paragraphs. Otherwise, the risk is that there's too much text on some pages where this reusable is used, before the user gets to the "good stuff" so to speak.
Would you be happy to make that further change (deleting the blank line)?
@subatoi I was just copying content from #36649 (comment) and trying to adjust the text to match the github data stuff. I have no opinion. But, please feel free to apply whichever changes and merge. |
No problem, will do—thank you as always for your help! |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following: