Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace GitHub with data variable #36757

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Mar 11, 2025

Why:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

⚠️ Warning: Our review server is experiencing latency issues.

The table shows the files in the content directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the data directory are not included in this table.

Source Review Production What Changed
actions/administering-github-actions/usage-limits-billing-and-administration.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
from reusable
actions/writing-workflows/choosing-what-your-workflow-does/storing-and-sharing-data-from-a-workflow.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
from reusable
billing/managing-billing-for-your-products/managing-billing-for-github-actions/about-billing-for-github-actions.md fpt
ghec
fpt
ghec
from reusable
billing/managing-billing-for-your-products/managing-billing-for-github-actions/managing-your-spending-limit-for-github-actions.md fpt
ghec
fpt
ghec
from reusable
enterprise-onboarding/github-actions-for-your-enterprise/about-billing-for-github-actions.md ghec
ghec
from reusable
get-started/learning-about-github/githubs-plans.md fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
fpt
ghec
ghes@ 3.16 3.15 3.14 3.13 3.12
from reusable

Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server

🤖 This comment is automatically generated.

subatoi
subatoi previously approved these changes Mar 11, 2025
Copy link
Contributor

@subatoi subatoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsoref, I've also added a missing full stop. I also think that given this is in a reusable, it would be better with an abbreviated linking sentence as in my suggestion, and removing the new blank line between the paragraphs. Otherwise, the risk is that there's too much text on some pages where this reusable is used, before the user gets to the "good stuff" so to speak.

Would you be happy to make that further change (deleting the blank line)?

@subatoi subatoi added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Mar 11, 2025
@jsoref
Copy link
Contributor Author

jsoref commented Mar 11, 2025

@subatoi I was just copying content from #36649 (comment) and trying to adjust the text to match the github data stuff.

I have no opinion. But, please feel free to apply whichever changes and merge.

@subatoi
Copy link
Contributor

subatoi commented Mar 12, 2025

No problem, will do—thank you as always for your help!

@subatoi subatoi enabled auto-merge March 12, 2025 08:44
@subatoi subatoi added this pull request to the merge queue Mar 12, 2025
Merged via the queue into github:main with commit 3ee2a00 Mar 12, 2025
42 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@jsoref jsoref deleted the issue-36649-followup branch March 12, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants