Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UnversionedImmutableAction.ql to experimental #18945

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

aeisenberg
Copy link
Contributor

This query will give too many false positives for users until immutable actions is released.

@Copilot Copilot bot review requested due to automatic review settings March 6, 2025 22:30
@aeisenberg aeisenberg requested a review from a team as a code owner March 6, 2025 22:30
@github-actions github-actions bot added documentation Actions Analysis of GitHub Actions labels Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the change note for the unversioned immutable action query to clarify that it has been moved to the experimental folder to reduce false positives.

  • Updated change note content reflecting that the query is now experimental.
  • Clarified that the query must be explicitly added to code scanning configurations.

Reviewed Changes

File Description
actions/ql/src/change-notes/2025-02-27-immutable-actions-list.md Updated changenote to indicate the query is moved to experimental and won’t run by default

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

adityasharad
adityasharad previously approved these changes Mar 6, 2025
This query will give too many false positives for users until
immutable actions is released.
@aeisenberg aeisenberg merged commit e73745d into main Mar 7, 2025
11 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/move-to-experimental branch March 7, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Actions Analysis of GitHub Actions documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants