Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed micromatch #2797

Closed
wants to merge 5 commits into from
Closed

Removed micromatch #2797

wants to merge 5 commits into from

Conversation

ayush1009208
Copy link

@ayush1009208 ayush1009208 commented Mar 6, 2025 •
edited
Loading

Merge / Deployment Checklist

  • Backward Compatibility:

    • Verified that these changes do not break existing workflows by running tests and validating behavior in a sample workflow.
    • Ensured compatibility with different environments.

  • [x]README Update:

    • Updated README.md to reflect the new changes, including configuration details and usage instructions.

  • Changelog Update:

@ayush1009208 ayush1009208 requested a review from a team as a code owner March 6, 2025 17:57
aeisenberg
aeisenberg requested changes Mar 6, 2025
View reviewed changes
package.json
Comment on lines -59 to -61
"//": [
"micromatch is an unspecified dependency of ava"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but please re-run npm -i and commit any changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing

aeisenberg
aeisenberg reviewed Mar 6, 2025
View reviewed changes
@aeisenberg
Copy link
Contributor

All of the windows tests are failing because there are paths that are too long. I suspect this is because of the symlinks in the node_modules folder. I am not sure why they were added. Can you remove all of the symlinks and and all of the *.cmd and *.ps1 files?

@aeisenberg aeisenberg added the Update dependencies Trigger PR workflow to update dependencies label Mar 7, 2025
@ayush1009208
Copy link
Author

Can you remove all of the symlinks and and all of the *.cmd and *.ps1 files?

Sure

@aeisenberg aeisenberg mentioned this pull request Mar 7, 2025
Open
3 tasks
@aeisenberg
Copy link
Contributor

I'm not sure what's happening in this PR. I'm closing this and going to use this one instead. Thanks for your contribution.

@aeisenberg aeisenberg closed this Mar 7, 2025
@ayush1009208
Copy link
Author

I'm not sure what's happening in this PR. I'm closing this and going to use this one instead. Thanks for your contribution.

Thanks for the review sir...I am new to open source contributions just trying to improve....if you have any issues that are suitable for me plz suggest I will be greatful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeisenberg aeisenberg aeisenberg requested changes

Assignees
No one assigned
Labels
Update dependencies Trigger PR workflow to update dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ayush1009208 @aeisenberg