Fix quadratic list indexing in commonmark/man/plaintext output formats #322
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #321
This adds some code to
cmark_render()
to calculate the correct list item index and store it on the node, so that output formats like commonmark don't have to calculate it themselves.Nodes of type
CMARK_NODE_ITEM
store the same kind of data asCMARK_NODE_LIST
, as can be seen here:cmark-gfm/src/blocks.c
Lines 1371 to 1376 in c4de252
So I decided to use the
start
field to store the index.