bugfix: Respect n_predict=-2 in server (#12264) #12323
Open
+27
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #12264: Eval bug: server API endpoint not respecting n_predict with -2 (until context filled).
Previously, if you set
n_predict
to -2, the server would ignore that it had a special meaning, and immediately stop producing tokens withreason
aslength
.After the change, we get this (correct) output:
We now indeed stop for
length
, but only after producing4096
completion tokens.