Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in minicpm-v code #11513

Merged
merged 4 commits into from
Mar 10, 2025
Merged

Conversation

tc-mb
Copy link
Contributor

@tc-mb tc-mb commented Jan 30, 2025

I found some bugs that caused loss of precision, here is the fix code.

  1. The mmproj of minicpm-v has precision issues, I have modified it and re-uploaded hf.
  2. The scheme of minicpm-v2.6 has issues, I have fixed it.
  3. There is a bug in minicpm-v conversion script, I have fixed it.

@github-actions github-actions bot added examples python python script changes labels Jan 30, 2025
@apepkuss
Copy link

apepkuss commented Feb 1, 2025

Is it possible to update README-minicpmv2.6.md along with this PR? It seems outdated. Thanks!

Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, but I highly recommend to that that assertion in my comment, so the code is a bit easier to understand for new developers.

@tc-mb
Copy link
Contributor Author

tc-mb commented Feb 5, 2025

Optional, but I highly recommend to that that assertion in my comment, so the code is a bit easier to understand for new developers.

Yes, I think what you said is better. But I think this PR is a simple fix merge. I want to merge it as soon as possible so that everyone can use the minicpm-v model with better effects.

I want to optimize this directly in your refactoring. Do you think this is better?

@tc-mb
Copy link
Contributor Author

tc-mb commented Feb 5, 2025

Is it possible to update README-minicpmv2.6.md along with this PR? It seems outdated. Thanks!

sure, I will update it.

@tc-mb
Copy link
Contributor Author

tc-mb commented Mar 10, 2025

@ggerganov @ngxson
This is a small update to fix minicpmv bugs. The changes are very minor and the accuracy has been verified.
It may not have been noticed, so it has not been merged. Please see if it can be merged directly. thx ^_^

@ggerganov ggerganov merged commit 8352cdc into ggml-org:master Mar 10, 2025
49 checks passed
@tc-mb tc-mb deleted the fix-bug-in-minicpm-v-code branch March 11, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples python python script changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants