-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bug in minicpm-v code #11513
fix bug in minicpm-v code #11513
Conversation
Is it possible to update README-minicpmv2.6.md along with this PR? It seems outdated. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional, but I highly recommend to that that assertion in my comment, so the code is a bit easier to understand for new developers.
Yes, I think what you said is better. But I think this PR is a simple fix merge. I want to merge it as soon as possible so that everyone can use the minicpm-v model with better effects. I want to optimize this directly in your refactoring. Do you think this is better? |
sure, I will update it. |
@ggerganov @ngxson |
I found some bugs that caused loss of precision, here is the fix code.