Move validation from Device::create_texture_from_hal() to Device::create_texture()
#2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…create_texture()` --- Users encountered a segfault upon creating a texture when mip_level_count was set to 0 with (at least) Vulkan. This is due to wgpu's validation taking place after the API's texture is created. This change moves wgpu's validation to before the API's texture is created, introducing a friendly error instead of a segfault.
kvark
approved these changes
Sep 27, 2021
auto-merge was automatically disabled
September 27, 2021 04:21
Head branch was pushed to by a user without write access
Patryk27
pushed a commit
to Patryk27/wgpu
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
It seems the mipmap validation was originally fixed in #893, and then moved to
fn create_texture_from_halin #1609?Description
Users encountered a segfault upon creating a texture when mip_level_count was set to 0 with (at least) Vulkan.
This is due to wgpu's validation taking place after the API's texture is created.
This change moves wgpu's validation to before the API's texture is created, introducing a friendlier error instead of a segfault.
Testing
I ran the cube example with mip_level_count as 1, and again on 0.
With mip_level_count set to 0, wgpu now produces the error:
notes:
format_featuresis being created twice (probably not worth an api change), and validation will no longer happen in the unsafe hal code-paths.