Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support base index/instance #355

Closed
kvark opened this issue Sep 3, 2014 · 2 comments
Closed

Support base index/instance #355

kvark opened this issue Sep 3, 2014 · 2 comments
Labels
difficulty: average type: feature

Comments

@kvark
Copy link
Member

kvark commented Sep 3, 2014

http://www.opengl.org/wiki/Vertex_Rendering#Base_Index

This function will allow more efficient re-usal of meshes, possibly for Hematite.
This should be a part of the Slice, but we don't want Slice interface to explode.
@brendanzab
Copy link
Contributor

Don't we already have the begin/end points? What would need to be added?

@kvark
Copy link
Member Author

kvark commented Sep 4, 2014

The base index and the base instance. We don't have it. These are used with special calls:

glDrawElementsBaseVertex​
glDrawArraysInstancedBaseInstance​
glDrawElementsInstancedBaseInstance​

emberian added a commit to emberian/gfx-rs that referenced this issue Nov 7, 2014
@emberian
Implement base indexes
c04def3 
This removes `IndexCount`, as it will never be distinct from `VertexCount`,
and cleans up the `Slice` representation to factor out common fields with
names, because it was becoming unmanageable. Changes the `DrawCommand`
slightly to take a buffer handle when binding the index buffer, because the
size of the buffer is needed in the fallback for when base indexes are not
supported. This code path should be very rare.

First half of gfx-rs#355
emberian added a commit to emberian/gfx-rs that referenced this issue Nov 7, 2014
@emberian
Implement base instance
10584b3 
Closes gfx-rs#355
emberian added a commit to emberian/gfx-rs that referenced this issue Nov 7, 2014
@emberian
Implement base indexes
d9cd18c 
This removes `IndexCount`, as it will never be distinct from `VertexCount`,
and cleans up the `Slice` representation to factor out common fields with
names, because it was becoming unmanageable. Changes the `DrawCommand`
slightly to take a buffer handle when binding the index buffer, because the
size of the buffer is needed in the fallback for when base indexes are not
supported. This code path should be very rare.

First half of gfx-rs#355
adamnemecek pushed a commit to adamnemecek/gfx that referenced this issue Apr 1, 2021
@bors @kvark
Merge gfx-rs#356
ae5a78f 
356: Allow max_bind_groups to be missing, for now r=kvark a=kvark

Fixes  gfx-rs#355

Co-authored-by: Dzmitry Malyshau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: average type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kvark @brendanzab @emberian