Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor external link styling to use external_links_class #2801

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

welpo
Copy link
Contributor

@welpo welpo commented Feb 16, 2025

IMPORTANT: Please do not create a Pull Request adding a new feature without discussing it first.

The place to discuss new features is the forum: https://zola.discourse.group/
If you want to add a new feature, please open a thread there first in the feature requests section.

Since this is a small refactor, I did not discuss it first. Feel free to close this if it's not wanted!


Code changes

External link styling added in #2522 was implemented before the PR that added external link classes (#2717).

This PR follows up on both by refactoring the config so as to remove the external_links_no_referrer = true line, as it was just added as a workaround to style external links.

The styling is now done through the external class, by setting external_links_class = "external".

The site looks identical, before and after this change.

  • Are you doing the PR on the next branch?

Since it's tiny and only affects the docs/site, I'm targeting master. Let me know if you'd prefer this in next.

@Keats
Copy link
Collaborator

Keats commented Feb 17, 2025

you'll need to bump the zola version in https://github.com/getzola/zola/blob/maser/.github/workflows/docs.yml as well

@welpo welpo force-pushed the refactor/external-link-style branch from f7a765f to 9c601de Compare February 17, 2025 21:25
@welpo
Copy link
Contributor Author

welpo commented Feb 17, 2025

Done!

@Keats Keats merged commit 38a5a72 into getzola:master Feb 18, 2025
2 checks passed
@Keats
Copy link
Collaborator

Keats commented Feb 18, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants