ref(source-map-debugger-modal): Display different copies based on the release userAgent #86967
+160
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… release userAgent
…-based-on-user-agent-of-available
github-actions
bot
added
the
Scope: Frontend
…r-agent-of-available' of github.com:getsentry/sentry into priscila/ref/debugger-modal/display-copies-based-on-user-agent-of-available
…-based-on-user-agent-of-available
|
in this example it shows vite and sentry-cli? Shouldn't it only show one? It looks like the logic is based on the user-agent right?
|
|
@smeubank we show /render them separately, and based on my redash queries, we often have both 🤔 for the screenshot I had to manually set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the code to show custom messages in the Sentry debugger modal based on the user agent in the release. If the user agent isn't available, a more general message will be shown, as it is in production.
In the future, it would be helpful always to have the tool used to upload sourcemaps available - maybe this is something we can implement in the sentry-cli - but for now, we're using the user agent in the release to show a more specific message to the user.
Before
After
