Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(projects): Show ANR rate for Apple projects #86771

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Mar 11, 2025

Show the ANR rate for Apple projects and hide the foreground ANR rate. It's acceptable to still call it ANR rate, because the feature is hidden behind a feature flag. We will update the descriptions in an upcoming PR to rename ANR rate to App Hang rate; see GH-86666.

Feature flag PR: #86772.

Fixes GH-86665

Show the ANR rate for Apple projects and hide the foreground ANR rate.
It's acceptable to still call it ANR rate, because the feature is hidden
behind a feature flag. We will update the descriptions in an upcoming PR
to rename ANR rate to App Hang rate, see GH-86666.

Fixes GH-86665
@philipphofmann philipphofmann requested a review from a team as a code owner March 11, 2025 08:58
@philipphofmann philipphofmann self-assigned this Mar 11, 2025
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Mar 11, 2025
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #86771      +/-   ##
==========================================
+ Coverage   87.74%   87.82%   +0.07%     
==========================================
  Files        9823     9781      -42     
  Lines      555959   553741    -2218     
  Branches    21925    21622     -303     
==========================================
- Hits       487840   486325    -1515     
+ Misses      67688    67027     -661     
+ Partials      431      389      -42     

@philipphofmann philipphofmann removed the Scope: Backend Automatically applied to PRs that change backend components label Mar 11, 2025
@philipphofmann

This comment was marked as outdated.

@philipphofmann
Copy link
Member Author

@getsentry/issues I would highly appreciate a review of this PR please ⬆️ Or please let me know whom to ping for a PR review.

@philipphofmann
Copy link
Member Author

@shruthilayaj I asked @priscilawebdev who could review that PR, and your name came up 😃. FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App Hang Rate Apple: Show App Hangs Rate
1 participant