feat(mobile-ui): Render screen list table #70064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the default sort a function with release versions in it requires too much processing if it's not going to stick around.
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 70.97kB ⬆️
|
edwardgou-sentry
approved these changes
May 2, 2024
static/app/views/performance/mobile/components/screensTable.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries spans metrics for the new frame metrics and displays them in a table.
In doing this I realized I'm missing
transaction.opto filter forui.loadtransactions, but that will be fixed with getsentry/relay#3512, so for now I've removed that filter and left a TODO to replace it.I've also left TODOs to add a count column which we'll use to sort these screens by popularity. Since I haven't built out the screen detail page yet, the links don't route anywhere useful.