feat(metric-stats): Add cardinality.{limit,scope} tags to strings indexer #68891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Dav1dde
commented
Apr 15, 2024
| @@ -1,7 +1,7 @@ | |||
| from hashlib import sha256 | |||
|
|
|||
| LOCKED_FILE = "src/sentry/sentry_metrics/indexer/strings.py" | |||
| LOCKED_DIGEST = "609a019a93229c352ec38c2be6a0620bfd2964e00315258c32f1502b4bc14add" | |||
| LOCKED_DIGEST = "0ef936acdfde1efe71cfe4ba07ff9a736c27374c0ce5b5c22fcbcad36f8c8970" | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #68891 +/- ##
==========================================
- Coverage 79.72% 79.72% -0.01%
==========================================
Files 6423 6423
Lines 284723 284726 +3
Branches 49046 49048 +2
==========================================
- Hits 226998 226991 -7
- Misses 57327 57337 +10
Partials 398 398
|
Dav1dde
force-pushed
the
dav1d/cardinality-scope-string
branch
from
56ff86e to
20b520e
Compare
evanh
approved these changes
Apr 15, 2024
Dav1dde
changed the title
jjbayer
approved these changes
Apr 16, 2024
armenzg
pushed a commit
that referenced
this pull request
Apr 17, 2024
…exer (#68891) Adds `cardinality.scope` and `cardinality.limit` tags to strings indexer, to allow manual queries via cardinality analyzer spanning multiple/all orgs with a fixed metric id/tag id. The tag is unused in all indexer tables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: getsentry/relay#3147
Adds
cardinality.scopeandcardinality.limittags to strings indexer, to allow manual queries via cardinality analyzer spanning multiple/all orgs with a fixed metric id/tag id.The tag is unused in all indexer tables.