ref(relay): Make cardinality limits more configurable #68158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #68158 +/- ##
==========================================
- Coverage 79.39% 79.39% -0.01%
==========================================
Files 6380 6380
Lines 282789 282802 +13
Branches 48769 48771 +2
==========================================
+ Hits 224517 224523 +6
- Misses 57825 57832 +7
Partials 447 447
|
Dav1dde
force-pushed
the
dav1d/ref/card-conf-limits
branch
from
dd92e44 to
ec602e2
Compare
jjbayer
approved these changes
Apr 3, 2024
src/sentry/relay/config/__init__.py
Outdated
Comment on lines
291
to
293
| rollout_rate = clo.pop("rollout_rate", 1.0) | ||
| if (project.organization.id % 100000) / 100000 >= rollout_rate: | ||
| continue |
There was a problem hiding this comment.
nit: Could use the in_rollout_group utility here.
There was a problem hiding this comment.
I saw that but it requires an option to be passed :(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes cardinality limits for Relay more configurable, to be able to test and roll them out more easily.
dropfrom the sessions config was removed in getsentry/relay#3271 - required for the librelay update to work