feat(metric-stats): Add metric_stats generic metrics namespace #66955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Dav1dde
commented
Mar 14, 2024
Dav1dde
commented
Mar 14, 2024
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-namespace
branch
from
c72c122 to
a40c5ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66955 +/- ##
==========================================
- Coverage 84.31% 84.27% -0.04%
==========================================
Files 5309 5306 -3
Lines 237401 237255 -146
Branches 41059 41045 -14
==========================================
- Hits 200172 199954 -218
- Misses 37011 37083 +72
Partials 218 218
|
jjbayer
approved these changes
Mar 14, 2024
evanh
reviewed
Mar 14, 2024
| @@ -191,6 +191,12 @@ | |||
| "os.version": PREFIX + 271, | |||
| # Performance Score | |||
| "sentry.score_profile_version": PREFIX + 272, | |||
| # Metric stats | |||
| "mri": PREFIX + 273, | |||
There was a problem hiding this comment.
We just had an incident (INC-680) where adding new strings here broke existing strings in prod. Can you double check that none of these tags are in the indexer currently? Otherwise they will overwrite the old values and mess up the data.
There was a problem hiding this comment.
I did checked all of them (see PR description)
Dav1dde
force-pushed
the
dav1d/feat/metric-stats-namespace
branch
from
8dc35e7 to
4cad29c
Compare
iker-barriocanal
approved these changes
Mar 15, 2024
JonasBa
pushed a commit
that referenced
this pull request
Mar 17, 2024
Adds the `metrics_stats` namespace and some initial strings.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
metrics_statsnamespace and some initial strings.All strings added are currently unused.
Depends on a librelay release after: getsentry/relay#3267
Epic: getsentry/relay#3147