Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hybridcloud) Don't assign user to socialauth model #60556

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

markstory
Copy link
Member

Setting RpcUser into the SocialAuth model results in a runtime error. We don't use socialauth.user anywhere and not having it should be safe.

Fixes SENTRY-17QC
Fixes HC-994

Setting RpcUser into the SocialAuth model results in a runtime error. We
don't use `socialauth.user` anywhere and not having it should be safe.

Fixes SENTRY-17QC
Fixes HC-994
@markstory markstory requested a review from a team November 24, 2023 18:17
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #60556 (3ae77b3) into master (984670b) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #60556   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files        5185     5185           
  Lines      227925   227925           
  Branches    38345    38345           
=======================================
+ Hits       184238   184244    +6     
+ Misses      38064    38060    -4     
+ Partials     5623     5621    -2     

see 8 files with indirect coverage changes

@markstory markstory merged commit 578d82c into master Nov 24, 2023
@markstory markstory deleted the fix-17qc-socialauth branch November 24, 2023 20:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants