Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for profile.id #60012

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

RaduW
Copy link
Contributor

@RaduW RaduW commented Nov 15, 2023

This PR adds support for profile.id in rule conditions

resolves #59678

It is a counterpart to the equivalent functionality added in Relay in:
getsentry/relay#2715

@RaduW RaduW requested review from a team as code owners November 15, 2023 17:11
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 15, 2023
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #60012 (491da5e) into master (0365345) will decrease coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60012      +/-   ##
==========================================
- Coverage   80.76%   80.76%   -0.01%     
==========================================
  Files        5179     5179              
  Lines      227353   227360       +7     
  Branches    38249    38249              
==========================================
- Hits       183621   183618       -3     
- Misses      38145    38153       +8     
- Partials     5587     5589       +2     
Files Coverage Δ
src/sentry/snuba/metrics/extraction.py 90.97% <ø> (ø)
...tatic/app/components/events/eventViewHierarchy.tsx 87.50% <ø> (ø)

... and 11 files with indirect coverage changes

@RaduW RaduW merged commit ba674cd into master Nov 16, 2023
@RaduW RaduW deleted the feat/metrics/custom_rules_has_profile_id branch November 16, 2023 08:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for has:profile.id in investigation bias
2 participants