-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrub sensitive query param values from Replay URLs #49495
Labels
Comments
Assigning to @getsentry/support for routing, due by Monday, May 22nd at 12:13 pm (sfo). ⏲️ |
Routing to @getsentry/product-owners-replays for triage, due by Tuesday, May 23rd at 15:54 (yyz). ⏲️ |
Hey @cielt there's a PR here for tracking: getsentry/relay#2143 This will use platform and user-defined regexes to scrub PII. |
Super; thanks @cmanallen! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Problem Statement
When Replays are captured and associated with a navigation event (by URL), we see in some cases that sensitive query param values (e.g.,
jwt
or auth token) are displayed in full – either in a list view, ordered by URL, or on mouseover of some detail in a list of breadcrumbs.In the sentry.client.config.js for our frontend (React - Next.js) app, we currently use the
beforeBreadcrumb
andbeforeSend
hooks to scrub sensitive values (including instances of ajwt
param in URLs sent as part of a navigation or request breadcrumb, or in a stack trace). Is it possible to offer something like these hooks for Replays? Or some kind of config in the privacy & security settings that would address this?Please let me know if more info / context would be helpful; happy to supply what i can. Thanks very much!
Please see the attachments below for details:
1️⃣ Entire
jwt
param visible on mouseover of URL in breadcrumb2️⃣ Example of
jwt
param obfuscated withbeforeBreadcrumb
orbeforeSend
3️⃣ Screen recording showing
jwt
revealed in full on mouseoverhttps://github.com/getsentry/sentry/assets/3287153/3f405d17-51b5-495e-8c86-6191d80db9e3
Solution Brainstorm
No response
Product Area
Replays
The text was updated successfully, but these errors were encountered: