Migrate typing for core files #4500
Draft
+1,282
−1,711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sl0thentr0py
force-pushed
the
neel/typing
branch
2 times, most recently
from
193076c to
17827c2
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## potel-base #4500 +/- ##
==============================================
+ Coverage 80.91% 84.69% +3.78%
==============================================
Files 144 144
Lines 14821 14846 +25
Branches 2365 2367 +2
==============================================
+ Hits 11992 12574 +582
+ Misses 2109 1545 -564
- Partials 720 727 +7
|
sl0thentr0py
force-pushed
the
neel/typing
branch
9 times, most recently
from
f6d64a5 to
4b67774
Compare
sl0thentr0py
commented
Jun 20, 2025
| @@ -1,5 +1,4 @@ | |||
| from opentelemetry.context import create_key | |||
| from sentry_sdk.tracing_utils import Baggage | |||
There was a problem hiding this comment.
this was creating an unnecessary circular dep
sl0thentr0py
force-pushed
the
neel/typing
branch
from
4b67774 to
c458d9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from https://github.com/getsentry/sentry-python/pull/4487/files with lots of manual fixes
# type: blato inline types__future__.annotationsso that we can simply use forward annotations without wrapping them in strings like we did before, this simplifies things substantiallyTYPE_CHECKING, in the future it seems we should avoid usingTYPE_CHECKINGcompletely