feat(ourlogs): canonicalize paths from the logger integration #4336
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4336 +/- ##
==========================================
- Coverage 80.29% 80.29% -0.01%
==========================================
Files 142 142
Lines 15934 15937 +3
Branches 2726 2727 +1
==========================================
+ Hits 12794 12796 +2
- Misses 2263 2267 +4
+ Partials 877 874 -3
|
sentrivana
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
LGTM but please address comment before merging @colin-sentry. A test case would also be awesome
sentry_sdk/integrations/logging.py
Outdated
| @@ -374,7 +375,10 @@ def _capture_log_from_record(client, record): | |||
| if record.lineno: | |||
| attrs["code.line.number"] = record.lineno | |||
| if record.pathname: | |||
| attrs["code.file.path"] = record.pathname | |||
| if record.pathname.startswith(project_root): | |||
There was a problem hiding this comment.
project_root might be None so we need to be more careful here:
Suggested change
| if record.pathname.startswith(project_root): | |
| if project_root is not None and record.pathname.startswith(project_root): |
There was a problem hiding this comment.
done, test added too
colin-sentry
force-pushed
the
canonicalize_logger_paths
branch
from
d946062 to
81797d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like to allow linking to the 'source code' line in the logs page - this canonicalizes the path relative to the project root (if one is defined)
Solves LOGS-58