Cleanup span is not None checks for TWP

[sl0thentr0py]

because of #3748 span can now be an INVALID_SPAN we have to cleanup the fallback cases for TWP to work properly.

also:

• better potel scope cleanup for tests
• rq was propagating only for the span case and not twp, fix this

[codecov]

❌ 1610 Tests Failed:

Tests completed	Failed	Passed	Skipped
19887	1610	18277	4412

View the top 1 failed tests by shortest run time

tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-00:00-expected_output4]

Stack Traces | 0.001s run time

tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined

View the full list of 2 ❄️ flaky tests

tests.test_utils test_datetime_from_isoformat[2021-01-01T00:00:00.000000-0000-expected_output6]

Flake rate in main: 40.74% (Passed 16 times, Failed 11 times)

Stack Traces | 0.001s run time

tests/test_utils.py:109: in test_datetime_from_isoformat
    assert datetime_from_isoformat(input_str) == expected_output, input_str
E   NameError: name 'datetime_from_isoformat' is not defined

tests.test_scope test_with_isolation_scope_data

Flake rate in main: 99.05% (Passed 2 times, Failed 209 times)

Stack Traces | 0.001s run time

tests/test_scope.py:387: in test_with_isolation_scope_data
    assert scope._tags == {"before_isolation_scope": 1}
E   AssertionError: assert {} == {'before_isolation_scope': 1}
E     
E     Right contains 1 more item:
E     {'before_isolation_scope': 1}
E     
E     Full diff:
E     + {}
E     - {
E     -     'before_isolation_scope': 1,
E     - }

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github