-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
chore: Add cursor rules for dependency upgrades #16669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
||
When upgrading OpenTelemetry dependencies: | ||
1. Check the dependency's `package.json` after upgrade | ||
2. Verify none of its dependencies use `@opentelemetry/*` packages at v2.0.0 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: What's important is that any otel package is not on
- 2.x.x or
- 0.2xx.x or
- Any of its deps is bumping to those, e.g.
@opentelemetry/[email protected]
bumped to core 2.0.0 and instrumentation 0.200.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done with 87ee91d
yarn.lock
Outdated
@@ -10264,6 +10264,11 @@ atob@^2.1.2: | |||
resolved "https://registry.yarnpkg.com/atob/-/atob-2.1.2.tgz#6d9517eb9e030d2436666651e86bd9f6f13533c9" | |||
integrity sha512-Wm6ukoaOGJi/73p/cl2GvLjTI5JM1k/O14isD73YML8StrH/7/lRFgmg8nICZgD3bZZvjwCGxtMOD3wWNAu8cg== | |||
|
|||
atomic-sleep@^1.0.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
m: Why are there lockfile changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed these in my PRs too, wondering if cursor/claude related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happened because I tested out the prompt with two dependabot security warnings. I gave the cursor agent the dependabot warning and it used the dependency upgrade rule (this allowed me to test and iterate with it).
Co-authored-by: Armen Zambrano G. <[email protected]>
a4ff44e
to
87ee91d
Compare
I want to unleash an army of background agents to crunch through https://github.com/getsentry/sentry-javascript/security/dependabot?q=is%3Aopen+
To do this, I added some cursor rules for upgrading dependencies within the repo.
I also tested this out with two dependabot security warnings:
resolves https://github.com/getsentry/sentry-javascript/security/dependabot/615
resolves https://github.com/getsentry/sentry-javascript/security/dependabot/613