Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay: Add metrics.buffering and metrics.sample_rate options #2616

Merged
merged 2 commits into from
Oct 30, 2020

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Oct 29, 2020

Related PR: getsentry/relay#821

@vercel
Copy link

vercel bot commented Oct 29, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/g7oemba0z/sentry.dev
✅ Preview: https://sentry-docs-git-tonyo-patch-1.sentry.dev

@tonyo tonyo requested a review from jan-auer October 29, 2020 10:07

Global sample rate for all emitted metrics. Should be between 0.0 and 1.0. If outside that range,
the value will be normalized (negative values would become 0.0, positive larger than 1.0 become 1.0).
For instance, the value of 0.3 means that only 30% of the emitted metrics will be sent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we note that we apply simple random sampling?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a note about that

@tonyo tonyo merged commit fbda0ba into master Oct 30, 2020
@tonyo tonyo deleted the tonyo-patch-1 branch October 30, 2020 14:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants